Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow referencing profiles from the included config when using Include #3174

Open
davide125 opened this issue Nov 10, 2024 · 2 comments
Open
Labels

Comments

@davide125
Copy link
Contributor

davide125 commented Nov 10, 2024

mkosi commit the issue has been seen with

main

Used host distribution

Fedora Linux 41

Used target distribution

Fedora Linux 41

Linux kernel version used

No response

CPU architectures issue was seen on

None

Unexpected behaviour you saw

When using Include against a mkosi repo that defines profiles, the profiles cannot be referenced in the config. My expectation would have been to be able to reference them, and that if a profile existed in the config with the same name that would take precedence over the included one.

Used mkosi config

Given an empty directory with https://github.com/systemd/particleos cloned into the particleos directory and the following mkosi.conf

[Include]
Include=particleos

[Config]
Profiles=desktop

mkosi output

`‣ Profile 'desktop' not found in mkosi.profiles/`
@davide125 davide125 added the bug label Nov 10, 2024
@davide125
Copy link
Contributor Author

Worth noting that it looks like this can be workaround with something like

$ ls -l mkosi.profiles/
total 4
lrwxrwxrwx. 1 davide davide 37 Nov 10 15:23 desktop -> ../particleos/mkosi.profiles/desktop/

but that feels a bit hacky to me.

@DaanDeMeyer DaanDeMeyer added RFE and removed bug labels Nov 12, 2024
@DaanDeMeyer
Copy link
Contributor

Hmm, this feels like it'd a bit too flexible, I think your solution could actually be OK here. It makes it explicit that you're using a profile from somewhere else compared to explicitly picking that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants