Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom worker not loaded correctly #33

Open
ItsReddi opened this issue Apr 24, 2023 · 1 comment
Open

Custom worker not loaded correctly #33

ItsReddi opened this issue Apr 24, 2023 · 1 comment

Comments

@ItsReddi
Copy link

Error:

"Symplify\MonorepoBuilder\Release\Contract\ReleaseWorker\ReleaseWorkerInterface". Got: "workers\MonoRepo\TestWorker"

Setup:
monorepo-builder.php

<?php

declare(strict_types=1);

use Symplify\MonorepoBuilder\Config\MBConfig;
use Symplify\MonorepoBuilder\Release\ReleaseWorker\AddTagToChangelogReleaseWorker;
use Symplify\MonorepoBuilder\Release\ReleaseWorker\PushNextDevReleaseWorker;
use Symplify\MonorepoBuilder\Release\ReleaseWorker\PushTagReleaseWorker;
use Symplify\MonorepoBuilder\Release\ReleaseWorker\SetCurrentMutualDependenciesReleaseWorker;
use Symplify\MonorepoBuilder\Release\ReleaseWorker\SetNextMutualDependenciesReleaseWorker;
use Symplify\MonorepoBuilder\Release\ReleaseWorker\TagVersionReleaseWorker;
use Symplify\MonorepoBuilder\Release\ReleaseWorker\UpdateBranchAliasReleaseWorker;
use Symplify\MonorepoBuilder\Release\ReleaseWorker\UpdateReplaceReleaseWorker;
use Workers\MonoRepo\TestWorker;

return static function (MBConfig $mbConfig): void {
    $mbConfig->packageDirectories([__DIR__ . '/packages']);
    $mbConfig->defaultBranch('develop');
    $mbConfig->packageAliasFormat('<major>.<minor>.x-dev');

    // release workers - in order to execute
    $mbConfig->workers([
        UpdateReplaceReleaseWorker::class,
        SetCurrentMutualDependenciesReleaseWorker::class,
        AddTagToChangelogReleaseWorker::class,
        TagVersionReleaseWorker::class,
        PushTagReleaseWorker::class,
        SetNextMutualDependenciesReleaseWorker::class,
        UpdateBranchAliasReleaseWorker::class,
        PushNextDevReleaseWorker::class,
        TestWorker::class,
    ]);
};

src/TestWorker.php

<?php

namespace Workers\MonoRepo;
use Symplify\MonorepoBuilder\Release\Contract\ReleaseWorker\ReleaseWorkerInterface;

class TestWorker implements ReleaseWorkerInterface
{

    public function work(\PharIo\Version\Version $version) : void
    {
        echo "not implemented";
    }
    public function getDescription(\PharIo\Version\Version $version) : string
    {
        return "Does not work";
    }
}

psr-4 from composer.json:

    "require-dev": {
        "rector/rector": "0.15.24",
        "symplify/easy-coding-standard": "11.3.2",
        "symplify/monorepo-builder": "11.2.3.72",
    },
    "autoload": {
        "psr-4": {
            "Workers\\MonoRepo\\": "src"
        }
    },

vendor/bin/monorepo-builder release minor --dry-run

Result:

 [ERROR] Expected an instance of this class or to this class among its parents                                          
         "Symplify\MonorepoBuilder\Release\Contract\ReleaseWorker\ReleaseWorkerInterface". Got:                         
         "Workers\MonoRepo\TestWorker"   

It feels that it has something todo with the autoloading.

@outermedia-kha
Copy link

outermedia-kha commented Jun 2, 2023

Same for me, using version 11.2.3.72

@ItsReddi could you solve your issue?

Edit:

I was able to solve it by loading vendor/autoload.php in monorepo-builder.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants