Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Values LocalCoordinates is backwards #399

Open
aaron-skydio opened this issue Aug 20, 2024 · 1 comment
Open

C++ Values LocalCoordinates is backwards #399

aaron-skydio opened this issue Aug 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@aaron-skydio
Copy link
Member

#395 (comment)

Values::LocalCoordinates(v) produces v - this, which is the negative of what's used everywhere else. On the geo types and cam types, and Values.local_coordinates in Python, it returns this - v

@aaron-skydio aaron-skydio added the bug Something isn't working label Aug 20, 2024
@aaron-skydio
Copy link
Member Author

As far as which is correct, I think the convention everything else uses is more intuitive, plus it's much less of a breakage to change Values::LocalCoordinates than everything else.

Above all else though, they should all be consistent (all of the instance methods, at least)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant