Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update to ExecHandlers for mvdan.cc/sh #2127

Open
dtrudg opened this issue Aug 29, 2023 · 1 comment
Open

deps: update to ExecHandlers for mvdan.cc/sh #2127

dtrudg opened this issue Aug 29, 2023 · 1 comment
Labels
dependencies Pull requests that update a dependency file techdebt
Milestone
SingularityCE 4.3.0

Comments

@dtrudg
Copy link
Member

dtrudg commented Aug 29, 2023

Type of issue

tech debt

Description of issue

In mvdan.cc/sh v3.7.0, the setting of an interpreter ExecHandler was deprecated in favour of one or more ExecHandlers.

I have failed to make a single entry ExecHandlers work in the same way as ExecHandler, so for now the deprecation lint failure has been turned off.

We need to switch to the new ExecHandlers to allow migration to a future v4.
@dtrudg dtrudg added techdebt dependencies Pull requests that update a dependency file labels Aug 29, 2023
@dtrudg dtrudg mentioned this issue Aug 29, 2023
Merged
@dtrudg dtrudg added this to the SingularityCE 4.2.0 milestone Apr 26, 2024
@dtrudg
Copy link
Member Author

dtrudg commented Aug 12, 2024

Had another go at this today, and still can't make ExecHandlers work with only a single entry... no default / fallback.... so going to not let this block a 4.2 RC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file techdebt
Projects
None yet
Milestone
SingularityCE 4.3.0
Development

No branches or pull requests
1 participant
@dtrudg