Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to DNF/CNF methods #57

Merged
merged 8 commits into from
Sep 18, 2024
Merged

Updates to DNF/CNF methods #57

merged 8 commits into from
Sep 18, 2024

Conversation

daemontus
Copy link
Member

This PR fixed two problems:

  • The output of the DNF optimization algorithm was in some cases less optimized than we hoped for. This new approach should perform better in case the BDD contains a lot of shared sub-formulas (which would otherwise contain a lot of extra literals and sometimes clauses).
  • The DNF/CNF construction had a bug due to which it was dependent not on the size of the DNF/CNF, but on the number of paths in the resulting BDD, which can be sometimes substantial. The new algorithm is a bit more high-level (and should have more overhead), but its complexity shouldn't explode unless the resulting BDD explodes.

@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.59%. Comparing base (23d4c53) to head (75d8572).

Additional details and impacted files 
@@             Coverage Diff             @@
##           master      #57       +/-   ##
===========================================
- Coverage   90.87%   63.59%   -27.29%     
===========================================
  Files          27       26        -1     
  Lines        2093     1420      -673     
===========================================
- Hits         1902      903      -999     
- Misses        191      517      +326

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daemontus daemontus merged commit ec60322 into master Sep 18, 2024
10 checks passed
@daemontus daemontus deleted the dnf-tweaks branch September 18, 2024 09:24
@daemontus daemontus mentioned this pull request Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daemontus