Skip to content
This repository has been archived by the owner on Jan 3, 2020. It is now read-only.

Checks apply to all files ? #4

Open
hiimbex opened this issue Jun 20, 2018 · 3 comments
Open

Checks apply to all files ? #4

hiimbex opened this issue Jun 20, 2018 · 3 comments

Comments

@hiimbex
Copy link

hiimbex commented Jun 20, 2018

I'm not sure if this is intentional behavior, but right now the check runs apply to all files but only link to the files changed. See: https://github.com/probot/probot/pull/574/checks?check_run_id=4611898

@swinton
Copy link
Owner

swinton commented Jun 20, 2018

@hiimbex, thanks for the report and for linking to an example!

the check runs apply to all files but only link to the files changed

this is due to the way annotations are currently rendered, which I believe is being worked on as part of the Checks API beta. Until then, do you think some kind of feature as described in #3 could help here?

@hiimbex
Copy link
Author

hiimbex commented Jun 20, 2018

👍 yea it's honestly not a big deal at all, didn't even realize it would be a GH problem. I think I'd prefer the real GH fix over listing every file I wanna ignore as you suggested in #3, it just feels kind of like a hassle, for a check that's not required.

@j-f1
Copy link

j-f1 commented Jan 19, 2019

Agree, this should only look at files that are actually changed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants