Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaKit: Passing objects between threads #157

Open
lhoward opened this issue Nov 7, 2024 · 2 comments
Open

JavaKit: Passing objects between threads #157

lhoward opened this issue Nov 7, 2024 · 2 comments
Labels
javakit

Comments

@lhoward
Copy link
Contributor

lhoward commented Nov 7, 2024 •
edited
Loading

javaMethodLookup() uses the environment attached to the object, probably it should use the ambient (thread-specific) environment or the one that is passed in?

java_vm_ext.cc:599] JNI DETECTED ERROR IN APPLICATION: thread Thread[23,tid=1783,Native,Thread*=0xb40000718be7eb40,peer=0x1449d000,"Thread-4"] using JNIEnv* from thread Thread[1,tid=1631,Native,Thread*=0xb40000718be307b0,peer=0x72c1eb68,"main"]
                                                                                                    java_vm_ext.cc:599]     in call to GetObjectClass

From the JNI specs:

The JNI interface pointer is only valid in the current thread. A native method, therefore, must not pass the interface pointer from one thread to another. A VM implementing the JNI may allocate and store thread-local data in the area pointed to by the JNI interface pointer.

So, I think this is a bug. Is the fix as simple as adding an environment argument to javaMethodLookup()?
@lhoward
Copy link
Contributor Author

lhoward commented Nov 7, 2024 •
edited
Loading

It's not a huge issue because I can schedule things on the main thread but, would be nice to not need to do this (to avoid excess context switches).

@ktoso ktoso changed the title Passing objects between threads JavaKit: Passing objects between threads Nov 7, 2024
@ktoso ktoso added the javakit label Nov 7, 2024
@lhoward lhoward mentioned this issue Nov 7, 2024
Closed
lhoward added a commit to PADL/swift-java that referenced this issue Nov 7, 2024
@lhoward
Always use the ambient environment when resolving methods, so that ob…
a8a75c5 
…jects may

be passed between threads.

Fixes: swiftlang#157
lhoward added a commit to PADL/swift-java that referenced this issue Nov 7, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
2d8c595 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
@lhoward
Copy link
Contributor Author

lhoward commented Nov 8, 2024 •
edited
Loading

I just did this for now – PADL@c3f2314 – but obviously it's a workaround. I think I need upstream input as to what the right solution is, whether we remove javaEnvironment completely and always use the ambient environment. cc @DougGregor

lhoward added a commit to PADL/swift-java that referenced this issue Nov 8, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
71a4559 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
lhoward added a commit to PADL/swift-java that referenced this issue Nov 8, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
5b514d7 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
lhoward added a commit to PADL/swift-java that referenced this issue Nov 8, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
c3f2314 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
lhoward added a commit to PADL/swift-java that referenced this issue Nov 8, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
40bb0a1 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
lhoward added a commit to PADL/swift-java that referenced this issue Nov 8, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
d4bec53 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
@lhoward lhoward mentioned this issue Nov 8, 2024
Open
lhoward added a commit to PADL/swift-java that referenced this issue Nov 8, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
1f1c07b 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
lhoward added a commit to PADL/swift-java that referenced this issue Nov 9, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
b1fdbc6 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
lhoward added a commit to PADL/swift-java that referenced this issue Nov 9, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
5ef3d63 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
@lhoward lhoward mentioned this issue Nov 9, 2024
Open
lhoward added a commit to PADL/swift-java that referenced this issue Nov 9, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
42debb8 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
lhoward added a commit to PADL/swift-java that referenced this issue Nov 9, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
d145ee6 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
lhoward added a commit to PADL/swift-java that referenced this issue Nov 9, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
fd10935 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
lhoward added a commit to PADL/swift-java that referenced this issue Nov 9, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
98fd787 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
lhoward added a commit to PADL/swift-java that referenced this issue Nov 9, 2024
@lhoward
JavaKit: always use ambient javaEnvironment on Android
a1f776f 
This is not a real fix, I suspect the real fix is to remove javaEnvironment as
an instance variable on all platforms and always use the ambient environment
(as the JNI specification clearly states the environment cannot be shared
between threads).

Works around: swiftlang#157
@lhoward lhoward mentioned this issue Nov 11, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
javakit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ktoso @lhoward