(es/minifer): number = number * 1 edge case

[Le0Developer]

The optimization in #9903 has an edge case where number = number * 1 is converted into number = +number as caught here instead of the shorter number *= 1.

Playground

[kdy1]

Do you have a profiling result of real world gzip being actually larger?

[Le0Developer]

Interestingly, gzip is one byte longer with *= 1.
However brotli with *= 1 is 8 bytes smaller:

a.js is using number = +number, b.js has the old behavior of number*=1

-rw-r--r-- 1 leodev staff 119072 Jan 23 15:15 a.js.br
-rw-r--r-- 1 leodev staff 147519 Jan 23 15:15 a.js.gz
-rw-r--r-- 1 leodev staff 119064 Jan 23 15:16 b.js.br
-rw-r--r-- 1 leodev staff 147520 Jan 23 15:16 b.js.gz

Based on https://github.com/Austaras/swc/blob/6c92ae75da433febbfec89333b2211477063f10e/crates/swc_ecma_minifier/tests/projects/output/angular-1.2.5.js