-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom JS config file being checked as YAML #1358
Comments
Hi! Is it possible you still use svgo v1? Because js-yaml is not used in v2. |
Yes, I just realized that is the problem and filed boopathi/react-svg-loader#307 |
Resolutions would not help here. APIs are incompatible. |
Indeed, I was just trying to offer a point of reference in that repo in case anybody was curious regarding how simple the upgrade would be in that repo. Kind of like: "I tried just in case, but it really is a breaking change, just so you know". |
@TrySound there's been nearly a year of no activity in https://github.com/boopathi/react-svg-loader I wonder if - with your new org membership - do you think there's room in https://github.com/svg for some kind of bundler/rollup repo. If not, I'll just fork and move on, but I figured I'd ask. |
I'm actually planning similar tool on top of svgo. For now I recommend svgr. |
svgo.config.format.js
:When running
yarn svgo --pretty --config=svgo.config.format.js src/svgs/**/*.svg
I get the following error:... src/svgs/uncategorized/Volume-High.svg src/svgs/uncategorized/Volume-Low.svg src/svgs/uncategorized/Volume-Muted.svg YAMLException: end of the stream or a document separator is expected at line 4, column 10: plugins: extendDefaultPlugins(), ^ at generateError (/Users/kyle/Code/@air/air-core/node_modules/js-yaml/lib/js-yaml/loader.js:167:10) ...
The text was updated successfully, but these errors were encountered: