Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when serving non-existent file in SPA mode #1277

Open
powder-pony opened this issue Nov 26, 2023 · 1 comment
Open

Panic when serving non-existent file in SPA mode #1277

powder-pony opened this issue Nov 26, 2023 · 1 comment

Comments

@powder-pony
Copy link

When serving non-exisient file with --index and --spa, program will panic (IOT instruction (core dumped))

miniserve version: miniserve 0.24.0
OS: openSUSE x86_64

example:

ssss

@svenstaro
Copy link
Owner

Thanks. Apart from the fact that it shouldn't panic at this point, what do you think is the expected behavior? I think it should indeed just refuse to start as --spa --index without the file existing does indeed not make sense. We could handle this early in the program startup. Would you like to take a stab at this (and add a test while you're at it)? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants