feat: change active account on dapp login #3454
Conversation
| default: | ||
| return 0; | ||
| } | ||
| }); | ||
| const tokenSymbol = computed( | ||
| () => ProtocolAdapterFactory.getAdapter(account!.protocol).coinSymbol, | ||
| () => ProtocolAdapterFactory.getAdapter(account!.value.protocol).coinSymbol, |
There was a problem hiding this comment.
| () => ProtocolAdapterFactory.getAdapter(account!.value.protocol).coinSymbol, | |
| () => ProtocolAdapterFactory.getAdapter(account.value.protocol).coinSymbol, |
There was a problem hiding this comment.
Removed the unnecessary !
src/popup/components/Truncate.vue
Outdated
| @@ -3,6 +3,9 @@ | |||
| class="truncate" | |||
| :class="{ right }" | |||
| > | |||
| <span class="center-vertically"> | |||
There was a problem hiding this comment.
Why have you decided to add it inside Truncate component and not just part of AccountInfo?
There was a problem hiding this comment.
I moved it to AccountInfo as it's not necessary in Truncate
| @@ -340,7 +339,7 @@ export default defineComponent({ | |||
| position: relative; | |||
| margin: 0 auto; | |||
| width: 100%; | |||
| height: 100%; | |||
| height: 100vh; | |||
There was a problem hiding this comment.
What is the reason for that change?
There was a problem hiding this comment.
There was an issue when the extension opened as a popup (i.e. when logging in through a dapp or when signing transactions). The content of the popup that opened had a wrong height, which caused the buttons at the bottom to be cut. When that popup was resized, they disappeared altogether. The 100vh in combination with removing the justify-content: center; fixed this behavior. It did not seem to affect anything else according to my tests, but should be double checked.
There was a problem hiding this comment.
alex-k8
force-pushed
the
feat/change-active-account-on-dapp-login
branch
2 times, most recently
from
4f9a71f to
6f8a1e3
Compare
1 similar comment
| @@ -137,6 +121,7 @@ export default defineComponent({ | |||
| showBookmarked, | |||
| setAccountSelectType, | |||
| } = useAccountSelector(); | |||
| const { getAccountIcon } = useAccounts(); | |||
There was a problem hiding this comment.
getAccountIcon is not used in this component.
alex-k8
force-pushed
the
feat/change-active-account-on-dapp-login
branch
3 times, most recently
from
e1a50bf to
3324b06
Compare
1 similar comment
alex-k8
force-pushed
the
feat/change-active-account-on-dapp-login
branch
from
3324b06 to
f408531
Compare
alex-k8
force-pushed
the
feat/change-active-account-on-dapp-login
branch
from
f408531 to
04dbacd
Compare
|
LGTM |
closes: #3449
also fixes a UI issue on wallet connect popup's dimensions