-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dapp Wallet Connection - Ability to change active account on Login #3449
Comments
ACCEPTANCE CRITERIA:
PROTOTYPE REC: changeconnectingaccount.mp4DESIGN: Types of accounts: Select Account Modal: FIGMA REFERENCE: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=38393-287490&t=rgmLREuMfq8YDIFz-0 .................................................................... Imported account icon positioning at different UI spots: Figma reference 2: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=34330-306136&t=kszgJ7UevD26J6pi-0 |
@onvisions we should a wording, kindly ensure that dapp network matches the network used in the wallet. @alex-k8 please explore the ability to receive network from dapp and change it in the wallet upon connection, |
Providing the design as requested. Minor comment on my side will be that this message is meaningful only for dApps that allow changing the active network from their UI. And in the best case switching the network in the dApp UI will also auto-change the active network in the wallet we are currently connected with. I am just a bit concerned it might become a point of confusion to the users in case they don't have any option to change the network from a particular dApp they are using. Actually I have seen only a few dApps that have the option to select between mainnet/testnet in their UI. Users usually select this only in the wallet. VERSION 1 VERSION 2 |
Version 1. seems milder. About the message, I would propose the following. Ensure that wallet and dApp are connected to the same network before making any transaction. |
User shall be able through Wallet Connection Modal to switch active account on popup. Account switcher screen should be shown to the user.
Also it should be investigated if latest account that was used in the dapp, to be proposed to the user.
The text was updated successfully, but these errors were encountered: