feat: support ledger using usb transport #3453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to feature-support-ledger.wallet.z52da5wt.xyz, artifacts |
CedrikNikita
force-pushed
the
feature/support-ledger
branch
from
9aa6562 to
d7d4b6c
Compare
|
Deployed to feature-support-ledger.wallet.z52da5wt.xyz, artifacts |
CedrikNikita
force-pushed
the
feature/support-ledger
branch
from
d7d4b6c to
387adb8
Compare
|
Deployed to feature-support-ledger.wallet.z52da5wt.xyz, artifacts |
CedrikNikita
force-pushed
the
feature/support-ledger
branch
from
387adb8 to
759b22d
Compare
|
Deployed to feature-support-ledger.wallet.z52da5wt.xyz, artifacts |
|
If the Ledger does not have a aeternity account ( with AE on it), the Ledger import is doing nothing. No account is imported. |
|
Using the base aepp it is possible to add a Ledger account, which is importable. |
CedrikNikita
force-pushed
the
feature/support-ledger
branch
from
759b22d to
e2a6ae4
Compare
|
Deployed to feature-support-ledger.wallet.z52da5wt.xyz, artifacts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3439,
fixes #3457,
Current structure is far from perfect, would be easier in future to store actual
LedgerAccountobject provided by sdk, and also other accounts as an objects.