Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware Ledger Support #3439

Open
smaroudasunicorn opened this issue Dec 18, 2024 · 6 comments · May be fixed by #3453
Open

Hardware Ledger Support #3439

smaroudasunicorn opened this issue Dec 18, 2024 · 6 comments · May be fixed by #3453
Assignees

Comments

@smaroudasunicorn
Copy link
Collaborator

smaroudasunicorn commented Dec 18, 2024

  • Be able to connect Ledger Hardware Wallet as a new account (currently Nano S supported by SDK).
  • Sign messages and transactions with Hardware Ledger.

This is similar to airgap approach, UI have to be adjusted accordingly.

@onvisions
Copy link
Collaborator

onvisions commented Jan 3, 2025

@smaroudasunicorn @CedrikNikita would you please check the suggested design and confirm if it's ok, do we miss anything, so I can update the user story with more detailed Acceptance criteria.

Design for Ledger support:

PROTOTYPE REC:

Ledger.Support.1.mp4

DESIGN:

1. Connect with USB connection:

Image
Image
Image
Image
Image
Image
Image
Image
Image
Image
Image
Image

2. Connect with Bluetooth:

Image
Image
Image

3. Confirm transaction with Ledger device modal (+ Bitcoin and Ethereum accounts):

Image
Image
Image
Image

4. New place for imported account icons:

Image

Image

Image

FIGMA REFERENCE: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=31920-189947&t=KDWoIsYOpXKvNndF-0

@smaroudasunicorn
Copy link
Collaborator Author

I am ok, not sure if we will support BT Ledger in this implementation package. @CedrikNikita ?

@onvisions
Copy link
Collaborator

onvisions commented Jan 13, 2025

@smaroudasunicorn,

  1. I synced about it with @CedrikNikita and it turns out that we are currently able of supporting only USB connect. So I'm providing an MVP version without BT support:

Image

I'm suggesting to create separate user story in the backlog for USB/BT support with the existing design to be implemented at later stage if we have the time and resources.

  1. In our sync call with @CedrikNikita we also discussed account discovery, derivation and technical limitations related so it turns out that we will be able to directly fetch and display only accounts with previous activity.
    Nikita also suggested to include a way of adding a specific account by entering its index number. May be you should check with him about this feature and do we need to include it. I'm a bit confused about the account discovery limitations according to currently implemented logic.

As far as I get the idea it should be something like this:

image

Figma reference: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=38454-296364&t=frll1CkNtuBPisux-0

@smaroudasunicorn
Copy link
Collaborator Author

Importing Ledger account should not be available in mobile version

@onvisions
Copy link
Collaborator

onvisions commented Jan 17, 2025

@smaroudasunicorn @CedrikNikita following our discussion about the technical limitations and current implementation of Confirm on Ledger modal I'm suggesting the following minor design update (2 alternative versions to chose from):

Image

FIGMA REFERENCE:
https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=38610-291931&t=5pGUP4mbcB9kEXLT-0

@smaroudasunicorn
Copy link
Collaborator Author

i believe v1 emphasizes more the message to the user

@CedrikNikita CedrikNikita linked a pull request Jan 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@CedrikNikita @onvisions @smaroudasunicorn and others