Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watcher in PendingMultisigTransaction composable is not working #2743

Closed
CedrikNikita opened this issue Feb 23, 2024 · 2 comments · Fixed by #2776
Closed

Watcher in PendingMultisigTransaction composable is not working #2743

CedrikNikita opened this issue Feb 23, 2024 · 2 comments · Fixed by #2776
Assignees

Comments

@CedrikNikita
Copy link
Collaborator

CedrikNikita commented Feb 23, 2024

Reproducible at feat/eth-support

In order to reproduce:

  1. Create a proposal
  2. Go to the proposal details
  3. Refresh the page
  4. Return to the multisig dashboard
  5. Observe that proposal card would be active for every multisig account

This line will not allow the composable to set the watcher, when user will leave the proposal details page
https://github.com/superhero-com/superhero-wallet/blob/feat/eth-support/src/composables/pendingMultisigTransaction.ts#L192

Image

@peronczyk peronczyk self-assigned this Feb 26, 2024
@peronczyk
Copy link
Collaborator

Additional bug that I found is that if two neighboring account has open transaction the amount displayed on the latest multisig transaction widget is not updating when switching between those accounts.

The task is now open for review and QA @Liubov-crypto

@Liubov-crypto
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants