-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System requirements for PHP are confusing (8.0 vs. 8.1) #217
Comments
Thank you for the feedback. Why So looking here I think we should update the docs to set the requirement to PHP 8.1 there for Sulu 2.5. Do you want to create a pull request for it? |
I found another notice:
|
Okay, that explains it, but it's not clear when you read the documentation, because it says version 8.0 and refers to the skeleton.
I will create a pull request on https://github.com/sulu/sulu-docs |
Yeah think change the docs that requirement is PHP 8.1 make sense as people reading that are mostly the ones which starting a new project and not working on an existing one. |
Actual Behavior
The skeleton requires PHP version 8.1 and higher:
skeleton/composer.json
Lines 29 to 30 in eb5158c
Sulu itself allows version 8.0 and higher:
https://github.com/sulu/sulu/blob/097a23c376f1fddbcdfdbd4f564f7847ec0cc934/composer.json#L27-L28
The documentation says PHP 8.0 and higher:
https://docs.sulu.io/en/2.5/reference/requirements.html
Expected Behavior
If Sulu allows version 8 of PHP and the documentation also lists this version under the system requirements, then the skeleton should allow the same version.
Steps to Reproduce
See above.
Possible Solutions
Update the Composer configuration of this package.
The text was updated successfully, but these errors were encountered: