-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard Controls #5
Comments
I have made it so that farmer faces moving direction and also keyboard inputs also I have added |
Tested, left a comment in one of the commits. The farmer turns, but the boat doesn't. The turn should be both. |
I have changed the Flipping and keyboard inputs |
Tested, the boat flips and the farmer flips but the farmer is still in the same position as before which isn't how it should work. The game starts out with him on the left, when the boat flips, he should be on the right as he flips, and the arrow buttons work but we still have to click to drop-off anything in the boat, this could be achieved with the spacebar. Why are the events being stored instead of processed as they occur? |
added spacebar action and made the held entity and farmer switch positions
The reason I have to do that is if I process pygame.events using |
Tested, if spacebar is pressed before any key then the game freezes and no other key event is handled. The logs show this; Traceback (most recent call last):
File "/home/ibiam/Activities/river-crossing-activity/main.py", line 103, in run
self.update_function()
File "/home/ibiam/Activities/river-crossing-activity/views/game.py", line 289, in update
boat_click_action()
File "/home/ibiam/Activities/river-crossing-activity/views/game.py", line 85, in boat_click_action
define_objects(left=left)
File "/home/ibiam/Activities/river-crossing-activity/views/game.py", line 116, in define_objects
obj = Obj(gap * (i + 1) + land_object_width * i,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: 'NoneType' object is not callable
Have you looked at |
event.poll is behaving weird, fails to catches events sometimes, especially key presses |
I have fixed the boat clicck bug |
It basically gets an event from the queue, if it doesn't behave as intended then you can leave it. |
Tested 452134f, works as expected. When the sheep is on the boat, clicking on the leg seems to be the only way to drop it, this is besides the spacebar. |
Oh, I noticed that |
I can take a look later. |
I have updated the icon for this activity as well so that it adapts to Sugar colors. After you take a look at the sheep leg issue, We can also make a release for this activity. |
I haven't been able to take a look into this, not sure I can at the moment. |
so can we package and release the activity? honestly, I do not reckon this issue would be noticeable to players |
Yes we can package and release it, see our maintainer check list. I can handle uploading them to aslov4 after you make the releases. |
No description provided.
The text was updated successfully, but these errors were encountered: