Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning CS0618: VsTest Console Wrapper 'The async APIs don't work, use the sync API instead.' #2853

Closed
rouke-broersma opened this issue Feb 16, 2024 · 4 comments
Labels
🐛 Bug Something isn't working

Comments

@rouke-broersma
Copy link
Member

Describe the bug
warning CS0618: 'IVsTestConsoleWrapperAsync.RunTestsWithCustomTestHostAsync(IEnumerable, string?, TestPlatformOptions?, ITestRunEventsHandler, ITestHostLauncher)' is obsolete: 'The async APIs don't work, use the sync API instead.'

warning CS0618: 'IVsTestConsoleWrapperAsync.DiscoverTestsAsync(IEnumerable, string?, ITestDiscoveryEventsHandler)' is obsolete: 'The async APIs don't work, use the sync API instead.'

@rouke-broersma rouke-broersma added the 🐛 Bug Something isn't working label Feb 16, 2024
@dupdob
Copy link
Member

dupdob commented Feb 16, 2024

PR #2845 fixes that properly: we need some form of async to recover from VsTest freezes

@dupdob
Copy link
Member

dupdob commented Feb 16, 2024

note that this (obsolete) attribute has been added by an external contributor to the VsTest codebase and is not substantiated in any way 😄
Yep, I was too cursory on this one

@rouke-broersma
Copy link
Member Author

nohwnd is not an external contributor, they work for microsoft on vstest. It was added here: microsoft/vstest#4648 and substantiated here: microsoft/vstest#4592

@dupdob
Copy link
Member

dupdob commented Mar 1, 2024

thanks for the rectification.
And indeed, the fact is that they async apis have little added value (except for somewhat better dealing with freezes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants