diff --git a/src/assets/styles/mixins.scss b/src/assets/styles/mixins.scss index 643507dd..d878bb86 100644 --- a/src/assets/styles/mixins.scss +++ b/src/assets/styles/mixins.scss @@ -144,8 +144,12 @@ } } -@mixin transition($props) { +// TODO replace $base-transition with this mixin. $base-transition is using `all` which is: +// 1) is highly unperformant, +// 2) can cause unexpected transitions +@mixin transition($props...) { transition-duration: 100ms; transition-property: $props; transition-timing-function: ease-in-out; + will-change: $props; } diff --git a/src/components/DataTable/index.ts b/src/components/DataTable/index.ts index fd63f6ac..063362e1 100644 --- a/src/components/DataTable/index.ts +++ b/src/components/DataTable/index.ts @@ -105,7 +105,6 @@ const SbDataTable = { this.deselectAll() } }, - selectedRows(value) { this.$emit('selected-rows', value) }, diff --git a/src/components/EmptyState/empty.scss b/src/components/EmptyState/empty.scss index 793ee433..7ed38014 100644 --- a/src/components/EmptyState/empty.scss +++ b/src/components/EmptyState/empty.scss @@ -22,6 +22,7 @@ } svg { + box-sizing: border-box; width: 100%; height: 100%; } diff --git a/src/components/Icon/icon.scss b/src/components/Icon/icon.scss index 2e0bb764..65fe78ac 100644 --- a/src/components/Icon/icon.scss +++ b/src/components/Icon/icon.scss @@ -40,7 +40,9 @@ $bg-colors: ( .sb-icon { display: inline-block; + flex-shrink: 0; vertical-align: middle; + user-select: none; @include setIconSize($icon-default-size); @include setIconColor(currentColor); diff --git a/src/components/Popover/SbPopover.vue b/src/components/Popover/SbPopover.vue index 15474e8e..ae85df62 100644 --- a/src/components/Popover/SbPopover.vue +++ b/src/components/Popover/SbPopover.vue @@ -15,7 +15,7 @@