Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revise: remove custom header checks #32

Closed
claymcleod opened this issue Mar 28, 2023 · 0 comments · Fixed by #33
Closed

revise: remove custom header checks #32

claymcleod opened this issue Mar 28, 2023 · 0 comments · Fixed by #33
Assignees
@claymcleod
Labels
bam Related to Binary Alignment Format (BAM) files cram Related to CRAM files revise A revision of existing functionality within the codebase sam Related to Sequence Alignment Map (SAM) files
Milestone
v0.5.0

Comments

@claymcleod
Copy link
Member

Custom parsing of the SAM/BAM/CRAM headers is no longer necessary, so we can remove ngs::utils::formats::sam::parse_header and associated functions.

Related materials
@claymcleod claymcleod added sam Related to Sequence Alignment Map (SAM) files bam Related to Binary Alignment Format (BAM) files cram Related to CRAM files revise A revision of existing functionality within the codebase labels Mar 28, 2023
@claymcleod claymcleod added this to the v0.5.0 milestone Mar 28, 2023
@claymcleod claymcleod self-assigned this Mar 28, 2023
claymcleod added a commit that referenced this issue Mar 28, 2023
@claymcleod
revise: removes custom header checks
b39e021 
Closes #32.
@claymcleod claymcleod mentioned this issue Mar 28, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claymcleod claymcleod

Labels
bam Related to Binary Alignment Format (BAM) files cram Related to CRAM files revise A revision of existing functionality within the codebase sam Related to Sequence Alignment Map (SAM) files
Projects
No open projects
[LEGACY] ngs
Status: Done
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

revise: removes custom header checks stjude-rust-labs/ngs
1 participant
@claymcleod