Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_cov_canonical(singletons = FALSE,hetgrid = NULL) should return a list with two matrices #40

Open
pcarbo opened this issue Dec 15, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@pcarbo
Copy link
Member

pcarbo commented Dec 15, 2021

Currently this outputs an empty list, e.g.,

> create_cov_canonical(3,singletons = FALSE,hetgrid = NULL)
named list()
@pcarbo pcarbo added the bug Something isn't working label Dec 15, 2021
@stephens999
Copy link
Collaborator

stephens999 commented Dec 15, 2021 via email

@gaow
Copy link
Member

gaow commented Dec 15, 2021

Related to #41 am leaning towards creating / reusing functions to provide the matrices, and repurpose the existing one in mvsusieR as set_mixture_prior to post-process or unify the output from sources outlined in #41, including that from cov_canonical if we reuse it.

@stephens999 we did some post-processing including scaling the cov_canonical by summary statistics if available so we get different values on the diag, and we allow for setting the weights for the matrices in the mixture although the default would be uniform weights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants