Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update block validation endpoint to return the processing time #5464

Open
obycode opened this issue Nov 15, 2024 · 2 comments
Open

Update block validation endpoint to return the processing time #5464

obycode opened this issue Nov 15, 2024 · 2 comments
Assignees
@obycode
Labels
tenure-extend

Comments

@obycode
Copy link
Contributor

obycode commented Nov 15, 2024 •
edited
Loading

In addition to reporting if the block is valid, the node should also report the block cost. EDIT: it already reports the block costs.

In addition to reporting if the block is valid, the node should also report the processing time.

See #5434.
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Nov 15, 2024
@jferrant
Copy link
Collaborator

Does it not already do this?

stacks-core/stackslib/src/net/api/postblock_proposal.rs

Line 146 in bac1b07

pub cost: ExecutionCost,

@obycode obycode assigned obycode and unassigned jferrant Nov 15, 2024
@obycode obycode changed the title Update block validation endpoint to return the cost Update block validation endpoint to return the processing time Nov 15, 2024
@obycode
Copy link
Contributor Author

obycode commented Nov 15, 2024

Does it not already do this?

Updated to add the processing time instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obycode obycode

Labels
tenure-extend
Projects
Stacks Core Eng
Status: Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obycode @jferrant