Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nakamoto] Update pox_3_test.rs to pox4_test.rs #4088

Closed
setzeus opened this issue Nov 24, 2023 · 4 comments
Closed

[Nakamoto] Update pox_3_test.rs to pox4_test.rs #4088

setzeus opened this issue Nov 24, 2023 · 4 comments

Comments

@setzeus
Copy link
Collaborator

setzeus commented Nov 24, 2023

This issue is meant to mark the kickoff, not completion of the pox4_test.rs that'll be worked in parallel to pox-4.clar. Since pox-4.clar work is still in the early stages, the only confirmed changes worth implementing at the moment revolve around the data structures defined in the design document:

https://docs.google.com/document/d/1IFTaHjEGHJkdFiEfKNayfmD0UlseoXpVcoMgJv0VW1g/edit#heading=h.tahn8ddco07r

@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Nov 24, 2023
@setzeus setzeus added this to the 0.3-Argon 3.0 milestone Nov 24, 2023
@setzeus setzeus changed the title [clarity] Update pox_3_test.rs to pox4_test.rs [Clarity] Update pox_3_test.rs to pox4_test.rs Nov 24, 2023
@setzeus setzeus changed the title [Clarity] Update pox_3_test.rs to pox4_test.rs [Nakamoto] Update pox_3_test.rs to pox4_test.rs Nov 24, 2023
@moodmosaic
Copy link
Member

@jcnelson @kantai @setzeus

In pox_4_tests.rs what should we use for the epoch and the activation height? In pox_3_tests.rs the latest one is 2.4

StacksEpoch {
    epoch_id: StacksEpochId::Epoch24,
    start_height: EMPTY_SORTITIONS + EPOCH_2_4_HEIGHT,
    end_height: STACKS_EPOCH_MAX,
    block_limit: ExecutionCost::max_value(),
    network_epoch: PEER_VERSION_EPOCH_2_4,
},

// ...

pox_constants.pox_3_activation_height = (EMPTY_SORTITIONS + EPOCH_2_4_HEIGHT + 1) as u32;
pox_constants.pox_4_activation_height = u32::MAX;

@moodmosaic
Copy link
Member

@setzeus it turns out there's existing work on this done by @jbencin (see #4106). I reached out to Jeff this morning. Perhaps it makes sense to close this and have just one issue open, so we can have a single place to discuss.

@setzeus
Copy link
Collaborator Author

setzeus commented Dec 4, 2023

Copy, closing this as a duplicate @moodmosaic

@setzeus setzeus closed this as completed Dec 4, 2023
@github-project-automation github-project-automation bot moved this from Status: 🆕 New to Status: ✅ Done in Stacks Core Eng Dec 4, 2023
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

3 participants