Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good ideas we didn't have time for #30

Open
Powersource opened this issue May 9, 2023 · 0 comments
Open

Good ideas we didn't have time for #30

Powersource opened this issue May 9, 2023 · 0 comments

Comments

@Powersource
Copy link
Contributor

Did we want to make a doc for this? Anyway noting down here for now so we don't forget.

  1. We wanted to put re-additions (addition to new epoch after exclude) but we ended up putting all add-member messages on the additions feed because
    1. There was a box2 bug Triangles should be constructed when new feeds are discovered ssb-box2#30
    2. As is also described in that bug, due to triangulation, you can only re-add someone if they've created their epoch feed for that epoch. This is a harder design problem, would maybe require scrapping triangulation
  2. As discussed in here Add oldSecrets field to add-member private-group-spec#33 , it's maybe smarter to put oldSecrets in epoch inits instead of in every new addition of a member. Probably slightly more complex though, but saves storage/bandwidth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant