-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In add-member, make groupKey an array? #16
Comments
Hmm it doesn't have to be a big array or anything. A new user actually only needs to be sent:
So maybe it doesn't have to be an array, but maybe instead something like |
So maybe simplest, if we want to deploy to prod before we have moderation, is to keep it as it is now and once we have moderation just also add a |
Ok getting ahead of things but brainstorming while it's in my head, when removing a member you'd publish 2 kinds of messages
|
Wait hmm giving them the root key only gives them access to the first 'epoch' right. Maybe giving them the current and the previous key though, since that'd let you go back one 'epoch' at a time, until you get to the root message. |
You can't go "backwards" through epochs... I think it's best to either:
We're gonna have an interesting thing with removal where we will need to be able to answer the question "who has which keys?" and get them the ones they are missing. I'm in favour of starting out simple |
doesn't work if you want to show the user the whole history. better to give them the previous key, then they can iterate backwards and finally get to the root key |
What do you mean? They can take the first, then replicate in order re-living the group history including invites and removals. I think doing something fancier is going to generate more edge cases and I'm scared we've got enough of those. TL;DR Open to looping back |
No they can't though? At least if they're a new member. It'll be equal to being added as a member to the initial epoch but being excluded from the second. Where would they get the keys to the epochs that aren't the first and the current? |
https://github.com/ssbc/private-group-spec/blob/master/group/add-member/README.md
A group will end up having multiple keys (i guess?) once we add member-removal since that will require key rotation, while we still want new members to be able to read old messages.
The text was updated successfully, but these errors were encountered: