New clothing - Carnival #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🖌️ Спрайты
|
@sourcery-ai review |
Reviewer's Guide by SourceryThis pull request adds new holiday and carnival clothing items to the game. It also adds outfits for three characters: Silko, Mel Medarda, and Kim Kitsuragi. Class diagram for new carnival clothing itemsclassDiagram
class CarnivalMask {
+name: string
+icon: string
+worn_icon: string
+flags_inv: int
}
class CarnivalSuit {
+name: string
+icon: string
+worn_icon: string
}
class CarnivalUnder {
+icon: string
+worn_icon: string
}
CarnivalMask <|-- FeatherMask
CarnivalMask <|-- HalfMask
CarnivalMask <|-- TrianglesMask
CarnivalMask <|-- ColoredMask
class FeatherMask {
+name: "Jester mask"
+greyscale_config
+flags_cover
}
CarnivalUnder <|-- FormalSuit
CarnivalUnder <|-- JacketSuit
CarnivalUnder <|-- DressCorset
CarnivalUnder <|-- DressFancy
CarnivalSuit <|-- IndustrialistCoat
CarnivalSuit <|-- KitsuragiJacket
note for CarnivalMask "Base class for all carnival masks"
note for CarnivalSuit "Base class for carnival outerwear"
note for CarnivalUnder "Base class for carnival clothing"
Class diagram for holiday clothing itemsclassDiagram
class HolidayClothing {
+name: string
+desc: string
+icon: string
+worn_icon: string
}
HolidayClothing <|-- NewYearSweater
HolidayClothing <|-- NewYearCloak
HolidayClothing <|-- Garland
class Garland {
+light_range: int
+light_power: float
+light_system: int
+color: string
}
note for HolidayClothing "Base class for holiday-themed items"
note for Garland "Can be worn as neck item or suit"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @m-dzianishchyts - I've reviewed your changes - here's some feedback:
Overall Comments:
- Several TODO comments and empty greyscale configuration files need to be addressed before this can be merged. Please complete the icon file updates and configurations.
- The PR adds new items but doesn't specify which vending machine they'll be available in. Please implement the vending machine access for these items.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Hey @m-dzianishchyts - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
dj-34
added
💩 Stale
PhantornRU
approved these changes
Jan 15, 2025
github-actions
bot
removed
the
💩 Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Добавляет пачку одежды за авторством @Fridh3lm, @EdinoroGNK, Sirstaniya.
Почему это хорошо для игры
Одежда круто!
Изображения изменений
Spoiler
Тестирование
Нашел предметы, надел, походил.
Changelog
🆑 Fredhelm, Edinorog, Sirstaniya, Maxiemar
add: Добавлены новогодние свитер, плащ и гирлянды (в качестве накидки и шарфа). Доступно в Autodrobe (other).
add: Добавлены костюмы, платья и карнавальные маски. Доступно в Autodrobe (fancy) в любом цвете.
add: Добавлены образы Силко, Мэл Медарды и Кима Кицураги.
/:cl:
Summary by Sourcery
Add new holiday and carnival clothing items, including sweaters, cloaks, garlands, masks, suits, and dresses. Also add character outfits for Silko, Mel Medarda, and Kim Kitsuragi.
New Features: