This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
[WIP] Lobby API 2.0 #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueDoctor
reviewed
Apr 11, 2020
lobby/src/server.rs
Outdated
| } | ||
|
|
||
| #[derive(Debug, Serialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| struct Game { | ||
| name: String, | ||
| type_: String, |
There was a problem hiding this comment.
I suggest using
#[serde(rename = "type")]
type_:String,to avoid needing to rename the variable on the frontend
There was a problem hiding this comment.
Ahhh, nice, this is still from my very first attempt where I didn't know about all the fancy serde helpers 😅
TrueDoctor
reviewed
Apr 11, 2020
TrueDoctor
force-pushed
the
lobby
branch
2 times, most recently
from
7edc540
to
4212e4e
Compare
This contains a simple HTTP-endpoint which serves the content relevant for the lobby and entrypoint of the entire ecosystem. For now, this is in its own subcrate, otherwise it would've been necessary to enhance the websocket-code to serve HTTP traffic on ports 80/443 as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic state of the new lobby-api. Please note that this is on top of #58.
I'm open for suggestions, but please keep in mind that a lot of this is pretty hacky atm to get a first proof-of-concept.
ToDo:
watch-support incargo-make/api/lobbyendpoint with demo-datalobbylobbywithrask-backend