Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support observations in Spring Boot starter #147

Closed
6 tasks
onobc opened this issue Sep 27, 2022 · 0 comments · Fixed by #158
Closed
6 tasks

Support observations in Spring Boot starter #147

onobc opened this issue Sep 27, 2022 · 0 comments · Fixed by #158
Assignees
Milestone

Comments

@onobc
Copy link
Collaborator

onobc commented Sep 27, 2022

Once observations are in the core for send/receive let's make it easier for end users to consume.

Easily disable/enable

  • Add property to en/disable observations for send, receive, globally

Easier customization

  • Make it easier for users to add custom tags. As it stands they would need to code up a convention and set it on the observed target. Let's at least create a convention customizer that can be auto-configured. NOTE: SB auto-configures observation registry and other components. Can we leverage this in any way?

Docs

  • Make sure there is an easy to follow section in docs telling how end user can use this.
  • Make sure there is an easy to follow section in docs telling how end user can access the built-in Pulsar consumer/producer stats.

Random cleanup

  • Revisit the observation if/else blockage in the send/receive methods to clean it up possibly

Verify

@onobc onobc added this to the 0.1.0-M2 milestone Sep 27, 2022
@onobc onobc self-assigned this Sep 27, 2022
onobc added a commit to onobc/spring-pulsar that referenced this issue Oct 5, 2022
onobc added a commit to onobc/spring-pulsar that referenced this issue Oct 5, 2022
onobc added a commit to onobc/spring-pulsar that referenced this issue Oct 7, 2022
sobychacko pushed a commit that referenced this issue Oct 7, 2022
onobc added a commit to onobc/spring-pulsar that referenced this issue Oct 12, 2022
Also documents how to configure Micrometer Observations.

See spring-projects#147
onobc added a commit that referenced this issue Oct 12, 2022
Also documents how to configure Micrometer Observations.

See #147
@onobc onobc modified the milestones: 0.1.0-M2, 0.1.0 Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant