Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user friendly error when Java < 17 is used #280

Closed
arey opened this issue Oct 1, 2024 · 6 comments
Closed

Add user friendly error when Java < 17 is used #280

arey opened this issue Oct 1, 2024 · 6 comments
Labels
enhancement

Comments

@arey
Copy link
Member

arey commented Oct 1, 2024

See spring-projects/spring-petclinic@7b1abb3
@AnkushThakur27
Copy link
Contributor

AnkushThakur27 commented Nov 12, 2024 •
edited
Loading

@arey can i pickup this ? and one more questions do i need to add for all microservices ?

@arey
Copy link
Member Author

arey commented Nov 12, 2024

Sure it is a good first issue

@AnkushThakur27
Copy link
Contributor

@arey WIP

@AnkushThakur27
Copy link
Contributor

@arey Sorry to bother you but I am not able to push my code chages due to permission issue. Can you add me as contributer ?

My User name : AnkushThakur27
email : [email protected]

20:44:16.918: [spring-petclinic-microservices] git -c credential.helper= -c core.quotepath=false -c log.showSignature=false push --progress --porcelain origin refs/heads/feature/#280:refs/heads/feature/#280 --set-upstream
remote: Permission to spring-petclinic/spring-petclinic-microservices.git denied to AnkushThakur27.

AnkushThakur27 added a commit to AnkushThakur27/spring-petclinic-microservices that referenced this issue Nov 12, 2024
@AnkushThakur27
Add user friendly error when Java < 17 is used (Issue spring-petclin…
74c13b1 
…ic#280)
@AnkushThakur27
Copy link
Contributor

Hi @arey Please review my pr : #286

AnkushThakur27 added a commit to AnkushThakur27/spring-petclinic-microservices that referenced this issue Nov 13, 2024
@AnkushThakur27
Removed Bracket [Issue spring-petclinic#280] fixed build
5a7af88
arey pushed a commit that referenced this issue Nov 14, 2024
@AnkushThakur27
Add user friendly error when Java < 17 is used (Issue #280) (#286)
f2c1422 
* Add user friendly error when Java < 17 is used (Issue #280)
* pom.xml updated
* java version property updated
* Removed Bracket [Issue #280] fixed build
@arey
Copy link
Member Author

arey commented Nov 14, 2024

Close thanks to @AnkushThakur27

@arey arey closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arey @AnkushThakur27