datetime.utcfromtimestamp() converts time.time() to wrong datetime value in luigi.tools.range.RangeBase

[wangzhe258369]

datetime.utcfromtimestamp() is used in the source code, which converts time.time() or self.now parameter value to the wrong datetime instance.

luigi/luigi/tools/range.py

Line 219 in 829fc0c

now = datetime.utcfromtimestamp(time.time() if self.now is None else self.now)

now = datetime.utcfromtimestamp(time.time() if self.now is None else self.now)

It should be:

now = datetime.fromtimestamp(time.time() if self.now is None else self.now)

[VishalGawade1]

Hey @RRap0so!

I would like to contribute on this. I saw the issue with datetime.utcfromtimestamp() giving the wrong time. I think switching it to datetime.fromtimestamp() could fix it and return the correct local time.

Let me know!

[dlstadther]

This bit of code has existed in the repo for 10 years now. The case where this would produce unexpected results is when this section of code is used on a system which has its time set to a non-UTC timezone.

I'm not saying this shouldn't be addressed, but we should be careful to think through what impact this could have if changes to either handle UTC or to handle local tz.