Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Ultimate Frisbee Fields #39

Open
errolkaylor opened this issue Jan 16, 2025 · 2 comments
Open

Adding Ultimate Frisbee Fields #39

errolkaylor opened this issue Jan 16, 2025 · 2 comments
Labels
new sport request When a new sport is requested for the package

Comments

@errolkaylor
Copy link

Hi Ross! I'm working on adding fields specific to Ultimate Frisbee here, and wanted to confirm the files that would need to be generated/updated -- does the following cover it?

  • surface_dimensions.json
  • geom_ultimate.R
  • features_ultimate.R

Best,
Errol
@rossdrucker rossdrucker added the new sport request When a new sport is requested for the package label Jan 16, 2025
@rossdrucker
Copy link
Collaborator

Yep! Those are the right files to update in terms of making the code work, but if it's not too much trouble, I'd also request that you update the README as well so it continues to reflect all sports/leagues covered by the package

@errolkaylor
Copy link
Author

Absolutely, thank you for the confirmation and reminder -- I'll get a pull request filed in the next couple of weeks hopefully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new sport request When a new sport is requested for the package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rossdrucker @errolkaylor