Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up brew-gem from being a single bin/file #16

Closed
NickLaMuro opened this issue Mar 18, 2015 · 2 comments
Closed

Split up brew-gem from being a single bin/file #16

NickLaMuro opened this issue Mar 18, 2015 · 2 comments

Comments

@NickLaMuro
Copy link

I think we have reached the extent that we can support brew-gem as a single file in a reasonable manner. There are no limitations in homebrew formulas that prevent us from having brew-gem installed as a bin executable and calling out to separate library files for parsing arguments, processing the installation, and using a template file for building the temp formula.

This obviously would take time to do right, but I would like to at least call out a few things that should be done when attempting to accomplish this:

  1. Tests. At a minimum, some unit tests, but possibly some integration tests via aruba or a similar framework.
  2. Split files out into their respective functions.
    • A lib for parsing arguments, probably making use of Ruby's OptionParser
    • Libs for handling searching for the gem, downloading of gem, building of the formula file, etc.
    • A separate template file for the formula.
  3. Avoid any external gem dependencies for deployment. We can make use of gems for test frameworks and such is fine, but I think trying to use external gems for the execution will be too cumbersome.
@anfleene
Copy link

I love this idea 👍 Lets do it.

@nicksieger
Copy link

Fixed by #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants