Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disconnect from warp client-side #25

Open
DannyBen opened this issue Jun 18, 2017 · 5 comments
Open

Add ability to disconnect from warp client-side #25

DannyBen opened this issue Jun 18, 2017 · 5 comments

Comments

@DannyBen
Copy link

When a client user connects with warp connect <id>, what do they need to do to disconnect?

The usual suspects of Ctrl+D, Ctrl+C or colon (:) did not work.

The solution, whatever it is, should probably be mentioned in the README.

@spolu
Copy link
Owner

spolu commented Jun 18, 2017

Hi @DannyBen!

Anything that quits the newly opened shell also disconnects the warp, as a warp is a shared shell instance. Do exit or Ctrl+D should work depending on the shell you use.

@spolu
Copy link
Owner

spolu commented Jun 18, 2017

I'll keep this one opened to update the README

@spolu spolu changed the title How to disconnect as a client user Update README: How to disconnect as a client user Jun 18, 2017
@DannyBen
Copy link
Author

The connecting client has no way of exiting then?... When sharing a read only warp session, the viewer cannot type exit and Ctrl+D does nothing.,,, what am I missing?

We were simply testing it with bash, although now that I think about it, maybe I started the session from within tmux, maybe this caused the other side to not be able to Ctrl+D...

@spolu
Copy link
Owner

spolu commented Jun 21, 2017

Fair point. Indeed Ctrl+D does not work client-side and should probably.
It is hinted here[0] that you should simply close your window, but that's definitely not clear.

[0] https://github.com/spolu/warp#automatic-client-terminal-resize

@spolu
Copy link
Owner

spolu commented Jun 21, 2017

Thanks @DannyBen

@spolu spolu changed the title Update README: How to disconnect as a client user Add ability to disconnect from warp client-side Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants