Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: configure Spin state dir #218

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: configure Spin state dir #218

wants to merge 1 commit into from

Conversation

kate-goldenring
Copy link
Collaborator

@kate-goldenring kate-goldenring commented Oct 29, 2024 •
edited
Loading

fixes #216

Mossaka
Mossaka approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you add this to the CHANGELOG?

@kate-goldenring
Copy link
Collaborator Author

This is also capturing logs, so we need to configure the dir for kv/sqlite but not for logs.

Logging component stdio to "/.spin/logs/"
Storing default SQLite data to "/.spin/sqlite_db.db".

Serving http://0.0.0.0:80
Available Routes:
  todo-api: http://0.0.0.0:80/api (wildcard)
  fileserver: http://0.0.0.0:80 (wildcard)

@kate-goldenring
fix: configure Spin state dir
e694770 
Signed-off-by: Kate Goldenring <[email protected]>
@kate-goldenring
Copy link
Collaborator Author

Resolved logs not being displayed by explicitly unsetting the log dir.

Storing default SQLite data to "/.spin/sqlite_db.db".

Serving http://0.0.0.0:80
Available Routes:
  todo-api: http://0.0.0.0:80/api (wildcard)
  fileserver: http://0.0.0.0:80 (wildcard)
Getting todos
Handler returned an error: Error::Io("no such table: todos")
Initializing migration
Getting todos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mossaka Mossaka Mossaka approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant jsturtevant is a code owner

@radu-matei radu-matei Awaiting requested review from radu-matei radu-matei is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spin state dir not being created
2 participants
@kate-goldenring @Mossaka