Slack notification broken

[lionslair]

I have been noticing this in bugsnag lately.

I was going to make a PR but then that PR will only work in newer I think 10.x version of laravel. Currently slack is using the old style not the new. eg https://laravel.com/docs/10.x/notifications#formatting-slack-notifications

What should the approach here be?

TypeError Illuminate\Notifications\Slack\SlackChannel::buildJsonPayload(): Argument #1 ($message) must be of type Illuminate\Notifications\Slack\SlackMessage, Illuminate\Notifications\Messages\SlackMessage given, called in /home/forge/kanopi.live/releases/20231018073733/vendor/laravel/slack-notification-channel/src/Slack/SlackChannel.php on line 38 
    vendor/laravel/slack-notification-channel/src/Slack/SlackChannel.php:63 Illuminate\Notifications\Slack\SlackChannel::buildJsonPayload
    vendor/laravel/slack-notification-channel/src/Slack/SlackChannel.php:38 Illuminate\Notifications\Slack\SlackChannel::send
    vendor/laravel/slack-notification-channel/src/SlackNotificationRouterChannel.php:41 Illuminate\Notifications\SlackNotificationRouterChannel::send
    vendor/laravel/framework/src/Illuminate/Notifications/NotificationSender.php:148 Illuminate\Notifications\NotificationSender::sendToNotifiable
    vendor/laravel/framework/src/Illuminate/Notifications/NotificationSender.php:106 Illuminate\Notifications\NotificationSender::Illuminate\Notifications\{closure}
    vendor/laravel/framework/src/Illuminate/Support/Traits/Localizable.php:19 Illuminate\Notifications\NotificationSender::withLocale
    vendor/laravel/framework/src/Illuminate/Notifications/NotificationSender.php:101 Illuminate\Notifications\NotificationSender::sendNow
    vendor/laravel/framework/src/Illuminate/Notifications/NotificationSender.php:79 Illuminate\Notifications\NotificationSender::send
    vendor/laravel/framework/src/Illuminate/Notifications/ChannelManager.php:39 Illuminate\Notifications\ChannelManager::send
    vendor/laravel/framework/src/Illuminate/Notifications/RoutesNotifications.php:18 Spatie\Health\Notifications\Notifiable::notify
    vendor/spatie/laravel-health/src/Commands/RunHealthChecksCommand.php:117 Spatie\Health\Commands\RunHealthChecksCommand::sendNotification
    vendor/spatie/laravel-health/src/Commands/RunHealthChecksCommand.php:34 Spatie\Health\Commands\RunHealthChecksCommand::handle
    vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:36 Illuminate\Container\BoundMethod::Illuminate\Container\{closure}
    vendor/laravel/framework/src/Illuminate/Container/Util.php:41 Illuminate\Container\Util::unwrapIfClosure
    vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:93 Illuminate\Container\BoundMethod::callBoundMethod
    vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:35 Illuminate\Container\BoundMethod::call
    vendor/laravel/framework/src/Illuminate/Container/Container.php:662 Illuminate\Container\Container::call
    vendor/laravel/framework/src/Illuminate/Console/Command.php:211 Illuminate\Console\Command::execute
    vendor/symfony/console/Command/Command.php:326 Symfony\Component\Console\Command\Command::run
    vendor/laravel/framework/src/Illuminate/Console/Command.php:180 Illuminate\Console\Command::run
    vendor/symfony/console/Application.php:1081 Symfony\Component\Console\Application::doRunCommand
    vendor/symfony/console/Application.php:320 Symfony\Component\Console\Application::doRun
    vendor/symfony/console/Application.php:174 Symfony\Component\Console\Application::run
    vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:201 Illuminate\Foundation\Console\Kernel::handle
    artisan:35 [main]

[frossi85]

We are experiencing the same issue, did you get to solve it?

[BernhardK91]

@lionslair I tried to create a PR on my own, but was not successfully yet. I would be happy if you can provide a PR. If I can contribute to it in any way, I'd be happy to.

[lionslair]

I'm going on holidays for two weeks won't be until I'm back

[BernhardK91]

@freekmurze Can you maybe share your opinion about breaking change in the package, especially as this is currently broken anyway? Or should there be a differentiation between the versions?

[BernhardK91]

The error message is thrown when an error occurs but the notification for the error failed.

In my case, php artisan config:show health revealed that in my case, the following parameters were not set in production:

notifications ⇁ slack ⇁ webhook_url ........................................
notifications ⇁ slack ⇁ channel ....................................... null

Setting those parameters also fixed the error message. But this is only a workaround, not a fix for the reported error message above.