NotificationMailSenderConfig - There should be no from key in $data

[mho22]

Trying out the newly released version 9.2.0 I encountered an unexpected issue when running composer install on a Laravel project where I don't have a MAIL_FROM_ADDRESS environment variable, even if I have a mail key in my config [ based on previous merged pull requests ].

I found out that in the NotificationMailSenderConfig file on line 18 :

public static function fromArray(array $data): self
{
    $address = $data['from']['address'] ?? config('mail.from.address');

   ...
}

There is a $data['from']['address'] instead of probably $data['address']. Basically because this is the MailSenderConfig so it doesn't have to go through the from key.

Furthermore, when I was looking for the location where NotificationMailSenderConfig::fromArray is called, in NotificationMailConfig.php on line 33:

public static function fromArray(array $data): self
{
    ...

    return new self(
        to: $data['to'],
        from: NotificationMailSenderConfig::fromArray($data['from'] ?? []),
    );
}

it was already passing the $data['from'] array as first parameter.

Should I suggest a PR to simply remove the ['from'] characters from NotificationMailSenderConfig ?

The reason why this has not been identified before is probably because every Laravel project has a MAIL_FROM_ADDRESS variable within its environment file.

[mho22]

@Nielsvanpach I hope this will be the last issue I post.