Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check code block on handle_data function #76

Open
SuelenKarbivnychyy opened this issue Aug 22, 2023 · 0 comments
Open

Check code block on handle_data function #76

SuelenKarbivnychyy opened this issue Aug 22, 2023 · 0 comments

Comments

@SuelenKarbivnychyy
Copy link
Contributor

SuelenKarbivnychyy commented Aug 22, 2023

On handle_data function line 245,

check about self.children.append(eval_result). ps: self.children is currently not being used.

code block:

if isinstance(eval_result, Component):
                        # this is a parent, right?
                        self.children.append(eval_result)      #TODO: Check with sanskar - this is a bug, we don't have self.children
                        return
@SuelenKarbivnychyy SuelenKarbivnychyy changed the title Check the code on handle_data function Check code block on handle_data function Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant