Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lower manysearch default threshold #379

Closed
ctb opened this issue Jul 3, 2024 · 1 comment · Fixed by #408
Closed

lower manysearch default threshold #379

ctb opened this issue Jul 3, 2024 · 1 comment · Fixed by #408

Comments

@ctb
Copy link
Collaborator

ctb commented Jul 3, 2024

per #302 (comment),

could we offer a different threshold too, e.g. minimum number of hashes? For very short query sequences, our default % threshold is far too stringent.
@ctb ctb changed the title adjust manysearch default threshold lower manysearch default threshold Jul 3, 2024
@ctb ctb mentioned this issue Aug 11, 2024
Merged
1 task
@ctb
Copy link
Collaborator Author

ctb commented Aug 12, 2024

actually, no 😭

per #388, query and target were flipped, which made 0.01 too stringent. Since we reversed this to the original meaning in #388, 0.01 refers to genome-in-metagenome, so 1% of the genome is present - which is good.

Life is pain.

@ctb ctb closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MRG: add pretty printing option to manysearch command sourmash-bio/sourmash_plugin_branchwater
1 participant
@ctb