Wrong encoding of Swift Date as a query param

[petrpavlik]

Describe the bug
It looks like encoding Swift Date as query params of GET requests does not work as expected. Looks like this code

soto-core/Sources/SotoCore/Encoder/RequestContainer.swift

Line 66 in 2614aa4

.map { (key: $0.key, value: "\($0.value)") }

uses standard description to turn a Date into a string which results in an URL looking like this:

https://email.us-east-1.amazonaws.com/v2/email/deliverability-dashboard/statistics-report/mail.indiepitcher.com?EndDate=2024-12-29%2023%3A19%3A50%20%2B0000&StartDate=2024-12-29%2023%3A19%3A50%20%2B0000

which seems to be rejected by AWS, at least for this particular endpoint. I have a repro when trying to get the sending domain statistics of SES.

To Reproduce
Steps to reproduce the behavior:

import SotoSESv2

let ses = SESv2(client: awsClient)
let statistics = try await ses.getDomainStatisticsReport(domain: "mail.indiepitcher.com", endDate: Date.now, startDate: Date.now)

Expected behavior
The request returns GetDomainStatisticsReportResponse

Actual behavior
The request fails with SerializationException: '2024-12-29 23:23:53 +0000' can not be converted to Date

Setup (please complete the following information):

• OS: Ubuntu
• Version of soto: 7.3.0
• Authentication mechanism hard-coded credentials

[adam-fowler]

Yeah query parameters are by-passing the encoder. Given pretty much all of them are strings and numbers, with some special cases for collections, that doesn't matter. Looks like you found an exception though.

[adam-fowler]

#632 should fix this

[petrpavlik]

Yes, checked the PR and looks great. Thanks!

[adam-fowler]

This has been released in soto-core 7.3.1