Marshal protobuf enums as strings

[marcogschmidt]

No description provided.

[yuval-k]

sounds like a breaking change..?

[marcogschmidt]

@yuval-k I think the change would not be breaking, as we unmarshal resources using the jsonpb.Unmarshal function, which can handle enums both when they have been serialized are strings and as ints.

I had created this issue as I thought that is was a prerequisite for a Gloo change, but it turns out it is not, so I don't think I will implement it right now. It would be good to do it at some point though, because currently the state of a resource is serialized as an int, which is not the best UX (e.g. a user will see state: 1, instead of state: Accepted). If we set EnumsAsInts to false on the marshaler that we use for the resource status, we would fix this without breaking backwards compatibility.

[yuval-k]

i meant for our users; the CRD shape is now different; if someone monitors it, expecting to see state: 1 then it might break them..
we can engage our users to see if that's a problem for them; i agree with you that the UX will be better with this change