Test SolidusBraintree SSF update with Venmo Pay

[gsmendoza]

Blockers

Depends on #102.

Requirements

Tester might need to be in US. Wasn't successful in faking a Venmo payment. See #102 (comment).

[gsmendoza]

@kennyadsl Like you suggested a few days ago, I've been able to check out with Venmo in development by setting force_buyer_country to 'US'. Will document the steps later.

CC @RyanofWoods

[RyanofWoods]

I tried that, but it didn't work for me @gsmendoza 🤔

[gsmendoza]

@RyanofWoods Weird, I was able to get it working earlier. Note the saved Venmo payment method in my app:

Will continue to test.

[gsmendoza]

@kennyadsl @RyanofWoods I'm getting the "Merchant account does not support payment instrument. (91577) Payment instrument type is not accepted by this merchant account. (91517)" error now :( Will just try again tomorrow...

[FrancescoAiello01]

Hey everyone, I was able to test it on my side since I'm located in the US. Here's how it went (going through the testing checklist):

Ensure the Venmo checkout button opens a modal with a QR code and is closeable.
This works as expected:

Screenshots

Do a full transaction
This works as expected:

Screenshots

Scanning the QR code takes me here:

Clicking confirm succeeds:

confirm succeeds:

Ensure that you can also save the payment source in the user wallet.

This works as expected. I'm also able to create another order in the admin interface using the user's saved payment source.

Screenshots

Ensure the saved Venmo wallet payment source loads in the partial correctly.

This looks right, but I'm not able to reuse the payment source on the user-facing flow:

Screenshots

Ensure the saved Venmo payment source can be reused for another order.

This only seems to work in the admin interface for me. In user-facing checkout I see the error in the above screenshot.

Test doing transactions on the admin

This works as expected:

Screenshots

Order created via admin:

Testing voiding and refunding Venmo transactions

Voiding works as expected, but I'm not able to test refunding because the payment state is stuck on Submitted For Settlement. Not sure if that's a nuance with the sandbox environment 🤔

[FrancescoAiello01]

I'm not super familiar with Braintree or this gem, so I might have messed something up. LMK if you want me to re-test anything in any specific way!

[RyanofWoods]

I am guessing the "all fields are empty error" is due to the card form being visible/not-disabled from previous experience.

[gsmendoza]

Thanks for the excellent work @FrancescoAiello01 . I'll test if I can reproduce the "all fields are empty" error with PayPal checkout.

[gsmendoza]

Hey @FrancescoAiello01! I didn't get the issue with a saved PayPal payment source. Can you debug handleVenmoSuccess in lib/generators/solidus_braintree/install/templates/app/assets/javascripts/spree/frontend/solidus_braintree/venmo_button.js? I think that function should be the one disabling the hosted field inputs.

I have also merged a PR to master, so you may also want to update your master branch.

[FrancescoAiello01]

Hey @FrancescoAiello01! I didn't get the issue with a saved PayPal payment source. Can you debug handleVenmoSuccess in lib/generators/solidus_braintree/install/templates/app/assets/javascripts/spree/frontend/solidus_braintree/venmo_button.js? I think that function should be the one disabling the hosted field inputs.

I have also merged a PR to master, so you may also want to update your master branch.

Sure I'll take a look!

[FrancescoAiello01]

I paired with @elia and we found that the import maps weren't working correctly in the solidus-starter-frontend. Regenerating the sandbox app fixed it. We also found that the credit card iframe is still interactable when the fieldset is disabled, so we created a small PR to fix that: solidusio/solidus_starter_frontend#326