Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope.registerDeclaration(declarationPath) error with vite-plugin-solid 2.8.2 #137

Open
floratmin opened this issue Jan 19, 2024 · 6 comments

Comments

@floratmin
Copy link

floratmin commented Jan 19, 2024

When updating vite-plugin-solid from version 2.8.0 to version 2.8.2 when I export a component as default I get the following warning:

The exported identifier "App" is not declared in Babel's scope tracker
as a JavaScript value binding, and "@babel/plugin-transform-typescript"
never encountered it as a TypeScript type declaration.
It will be treated as a JavaScript value.
This problem is likely caused by another plugin injecting
"App" without registering it in the scope tracker. If you are the author
 of that plugin, please use "scope.registerDeclaration(declarationPath)".
@SoundOfTheSky
Copy link

I have almost the same problem, but identifier is Input.

Problem dissapears once I roll back to 2.8.0, and appers in 2.8.1.
Apparently it's because of the bump of babel packages in solid-refresh lib.

@floratmin
Copy link
Author

If you export Input not as default it should not output this warning.

@ryansolid
Copy link
Member

Feels like we should move this to Solid Refresh then? @lxsmnsyc

@lxsmnsyc
Copy link
Member

Hmmm it can go both ways @ryansolid

I really wanted the #95 soon, but I'll still check Refresh for this.

@lxsmnsyc
Copy link
Member

Let us know if this still happens in ^2.9.0

@SoundOfTheSky
Copy link

The exported identifier "Input"... fixed. Thank you, @lxsmnsyc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants