You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am making SolidJS libraries for my organization. Some of the exports from this library are Signals. These signals aren't caught in the ESLint rule when using them improperly.
Note, this also applies to any other imported signal, even from within the same package.
To Reproduce
Create one file which calls createSignal and export the created signal.
Create another file which is a component that uses that imported signal improperly.
Expected behavior
In a perfect world, the ESLint rule would follow imports to find out which objects are signals. This could also possibly be accomplished via TypeScript type checking for Accessor types. But more realistically, it'd be great if the rule could be configured where we can manually list names of methods which should be treated as signals always.
Screenshots
Environment (please complete the following information):
OS: Windows 11
Node version (node --version): Node 20
eslint-plugin-solid version (npm list eslint-plugin-solid/yarn why eslint-plugin-solid): 0.13.1
eslint version (npm list eslint/yarn why eslint): 8.56.0
Additional context
N/A
I would be willing to contribute a PR to fix this issue
The text was updated successfully, but these errors were encountered:
Describe the bug
I am making SolidJS libraries for my organization. Some of the exports from this library are Signals. These signals aren't caught in the ESLint rule when using them improperly.
Note, this also applies to any other imported signal, even from within the same package.
To Reproduce
createSignal
and export the created signal.Expected behavior
In a perfect world, the ESLint rule would follow imports to find out which objects are signals. This could also possibly be accomplished via TypeScript type checking for
Accessor
types. But more realistically, it'd be great if the rule could be configured where we can manually list names of methods which should be treated as signals always.Screenshots
Environment (please complete the following information):
node --version
): Node 20eslint-plugin-solid
version (npm list eslint-plugin-solid
/yarn why eslint-plugin-solid
): 0.13.1eslint
version (npm list eslint
/yarn why eslint
): 8.56.0Additional context
N/A
The text was updated successfully, but these errors were encountered: