Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Trial Upload: fails with location codes #5129

Open
dwaring87 opened this issue Sep 27, 2024 · 1 comment
Open

Multi-Trial Upload: fails with location codes #5129

dwaring87 opened this issue Sep 27, 2024 · 1 comment
Assignees
Labels
Priority: Critical Issue/PR requires immediate resolution. Type: Bug Issue describes a bug.

Comments

@dwaring87
Copy link
Member

Expected Behavior

This earlier PR added the ability to use the location abbreviation/code instead of the full name for the location in the multi-trial upload.

The upload now silently fails (says the trials were added successfully but are not added to the database) if one or more trials use the location abbreviation/code in the location column. The upload plugin correctly validates the location code, but the additional location check in the upload_multiple_trial_design.pl script fails.

It might be a good idea to remove the location check in the perl script, since it's already being done by the plugin validation.

For Bugs:

Environment

Steps to Reproduce

@dwaring87 dwaring87 self-assigned this Sep 30, 2024
@dwaring87
Copy link
Member Author

The upload plugin is correctly replacing the location codes with the correct location name and returning that in the parsed data. However, the perl script is re-reading the original file and not using the parsed data from the plugin.

@lukasmueller lukasmueller added Priority: Critical Issue/PR requires immediate resolution. Type: Bug Issue describes a bug. labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical Issue/PR requires immediate resolution. Type: Bug Issue describes a bug.
Projects
None yet
Development

No branches or pull requests

2 participants