Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the setup for duplicate block local-cluster tests #34857

Open
AshwinSekar opened this issue Jan 19, 2024 · 0 comments
Open

Fix the setup for duplicate block local-cluster tests #34857

AshwinSekar opened this issue Jan 19, 2024 · 0 comments
Assignees
Labels
consensus Issues related to consensus bugs in the validator

Comments

@AshwinSekar
Copy link
Contributor

AshwinSekar commented Jan 19, 2024

Problem

After

  • test_duplicate_shreds_switch_failure() is flaky, fixup and reenable.
  • test_duplicate_shreds_broadcast_leader() does not test the case where duplicate proofs are disseminated through gossip, add 1 epoch delay to ensure gossip: notify state machine of duplicate proofs #32963 (comment) is tested
  • rework the setup for test_duplicate_shreds_broadcast_leader_ancestor_hashes(), so that it can be enabled. Currently the setup does not allow for a successful ancestor hashes response.
@AshwinSekar AshwinSekar self-assigned this Jan 19, 2024
@AshwinSekar AshwinSekar added the consensus Issues related to consensus bugs in the validator label Jan 19, 2024
@AshwinSekar AshwinSekar changed the title Fix the setup for test_duplicate_shreds_broadcast_leader Fix the setup for duplicate block local-cluster tests Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Issues related to consensus bugs in the validator
Projects
None yet
Development

No branches or pull requests

1 participant