Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a NixOS module to nixpkgs #325

Closed
Schweber opened this issue Jun 22, 2024 · 6 comments
Closed

add a NixOS module to nixpkgs #325

Schweber opened this issue Jun 22, 2024 · 6 comments

Comments

@Schweber
Copy link

Schweber commented Jun 22, 2024

First of all, thank you for your work and effort on this!

So far i haven't used flakes and am thus a bit hesitant about it. That's why i am wondering why you havent't added a niri module to NixOS (like the one for hyprland for example)?

I understand that using your flake provides more flexibility but i don't need that and would be happy with a "vanilla" module.

Would you consider adding one (while continuing your flake of course)?

@sodiboo
Copy link
Owner

sodiboo commented Jun 22, 2024

honestly there's no real reason i haven't done that. i just never got around to it because i didn't need it, using my own repo for the module.

if you want something right now, you could just copy the relevant options into your configuration. just replace cfg.package with pkgs.niri and you'll be good to go.

i'll see what i can do about adding a niri module to nixpkgs, it is some sort of long-term goal, but as i said, i just never got around to it. but with someone wanting that now, there is at least a good reason to stop procrastinating on it

@Schweber
Copy link
Author

Schweber commented Jun 22, 2024

Thanks! No need to hurry because of me though, i need to wait for niri 0.1.7 anyway because i depend on fractional scaling and it has just been commited to master. A NixOS Module would then make the switch easier for me 🙂.

@jonvemo
Copy link

jonvemo commented Jun 25, 2024

Please Add It! I'm waiting for 😸

@sodiboo sodiboo changed the title Why no module for NixOS? Why no module in nixpkgs? Jul 1, 2024
@sodiboo sodiboo changed the title Why no module in nixpkgs? add a NixOS module to nixpkgs Jul 1, 2024
@ocharles
Copy link

ocharles commented Jul 8, 2024

I personally think the flake is much better - it lets @sodiboo iterate much more rapidly. I would really suggest giving flakes a try and see if your skepticism holds up, it should be a quick experiment and easy to undo if you don't like it!

@sodiboo
Copy link
Owner

sodiboo commented Oct 24, 2024

that PR ^ was just merged, so i'd consider this as done. It'll make it into nixos-unstable soon enough (and it's also going to be part of the upcoming nixos-24.11), and after that point i'll provide a new module from this flake that builds on top of the upstream module.

If you use my NixOS module already, you will have to remove it to make use of the one in nixpkgs. They conflict with one another, so my module disables theirs. There isn't much immediate benefit to doing so, and as such i wouldn't necessarily recommend anyone do this yet, but if you do want to use that one you also have to remove this one first. Check out the implementation differences if you want to swap, because that module isn't just a clone of this one and you should verify that switching won't remove something you were relying on.

if you don't use my flake's modules, then go ahead and test the one from nixpkgs. previous paragraph doesn't apply to you, go wild lol.

@sodiboo sodiboo closed this as completed Oct 24, 2024
@Schweber
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants