Attempt of using generics instead of interface{} in component's configuration handling and creation.
#346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy to fix incorrect dep in go.mod
The default was changed to a naively long value when we implemented the feature - 60s is more reasonable
Original implementation did something silly and inefficient.
colmsnowplow
force-pushed
the
feat/batch-templating
branch
from
321429f
to
a80ea8d
Compare
configuration handling and creation. Drafted solution lives for now in `generic` package and example usage (with some fake test component) is demonstrated in `component_test.go`.
colmsnowplow
force-pushed
the
develop
branch
from
b3c04cb
to
d688908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drafted solution lives for now in
genericpackage and example usage (with some fake test component) is demonstrated incomponent_test.go.