Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the sampling workflow #116

Open
plastikfan opened this issue Jan 12, 2024 · 2 comments
Open

improve the sampling workflow #116

plastikfan opened this issue Jan 12, 2024 · 2 comments
Assignees
Labels
feature New feature or request

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Jan 12, 2024

Sample mode should not be considered transparent because typically the workflow would be:

  • run a smaple
  • inspect the result
  • perform full run

If transparent, then the originals are noved to the trash location, but this is a problem for a sample run, since the user would have to manually retrieve the original back to source location and re-run. Transparency is only good for a full run.

We need a better workflow.

BEFORE A NON TRANSPARENT RUN, ANY SAMPLE FILES FOUND IN THE SAME DIR AS THE ORIGIN SHOULD BE MOVED TO THE --output LOCATION. THE REASON FOR THIS IS THE USER MAY PERFORM A TRANSPARENT SAMPLE RUN, FOLLOWED BY A NON TRANSPARENT FULL RUN. IN THIS CASE, THE SAMPLE FILES WILL BE IN THE WRONG LOCATION AND SHOULD BE MOVED TO THE --output

@plastikfan plastikfan added the feature New feature or request label Jan 12, 2024
@plastikfan plastikfan self-assigned this Jan 12, 2024
@plastikfan
Copy link
Contributor Author

plastikfan commented Feb 26, 2024

🍎 plastikfan  …/pixa   feat/improve-the-sampling-workflow     v1.21.6   18:36 
 λ
push-feat
Enumerating objects: 95, done.
Counting objects: 100% (95/95), done.
Delta compression using up to 8 threads
Compressing objects: 100% (55/55), done.
Writing objects: 100% (55/55), 8.80 KiB | 530.00 KiB/s, done.
Total 55 (delta 40), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (40/40), completed with 31 local objects.
remote:
remote: Create a pull request for 'feat/improve-the-sampling-workflow' on GitHub by visiting:
remote:      https://github.com/snivilised/pixa/pull/new/feat/improve-the-sampling-workflow
remote:
To https://github.com/snivilised/pixa
 * [new branch]      feat/improve-the-sampling-workflow -> feat/improve-the-sampling-workflow
branch 'feat/improve-the-sampling-workflow' set up to track 'origin/feat/improve-the-sampling-workflow'.
✅ pushed feature to feat/improve-the-sampling-workflow ok!

Did not trigger a build on the branch feat/improve-the-sampling-workflow

@plastikfan
Copy link
Contributor Author

plastikfan commented Feb 28, 2024

migrated to go 1.22, which is now causing many lint errors to fire, that didnt so previouly, so these lint errors are bing fixed in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant