Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of invitations that do not expire #179

Open
mwild1 opened this issue Jan 16, 2024 · 0 comments
Open

Allow creation of invitations that do not expire #179

mwild1 opened this issue Jan 16, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mwild1
Copy link
Member

mwild1 commented Jan 16, 2024

Sometimes it's desired to create more permanent invitation links, e.g. to be able to print QR codes.

Links expire by default so if they leak in future (beyond the period of time they were expected to be used), they won't grant access to your server to someone unexpectedly. The more time passes, the more chance there is that the invitation will be forgotten about, and the more chance of it unintentionally leaking.

Taking this into consideration, we might want to do the following:

  • Warn the user before creating such an invitation
  • Periodically reminding the admin that permanent invitations are active (so they can review, and cancel any that are no longer being used)
  • Notify the inviter when someone registers using the invitation (this is something we want to do generally, for all invitations)
@mwild1 mwild1 added enhancement New feature or request good first issue Good for newcomers labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant