Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Snapshot's EIP4824 daoURI implementation #825

Open
5 tasks
thelastjosh opened this issue Mar 15, 2024 · 3 comments · May be fixed by #812
Open
5 tasks

Upgrading Snapshot's EIP4824 daoURI implementation #825

thelastjosh opened this issue Mar 15, 2024 · 3 comments · May be fixed by #812

Comments

@thelastjosh
Copy link

thelastjosh commented Mar 15, 2024

Hi folks,

After discussion a month ago (sorry for the delay!) with @bonustrack , posting an issue here to organize efforts to upgrade and finalize the current EIP4824 daoURI implementation. For examples, see https://hub.snapshot.org/api/eip4824/balancer.eth/ or https://hub.snapshot.org/api/eip4824/opcollective.eth/

I will continue to edit this issue to update the expected behavior over the next week or two.

Expected behavior

  • None of the subsidiary URIs (membersURI, proposalsURI, activityLogURI, or contractsURI return well-formed URLs. In particular, there is an extra / when appending the right information.
  • Changes to membersURI including pagination, uniqueness checks, etc. which is already underway at improve membersURI #812
  • Changes to contractsURI including clarifying the meaning of the address currently displayed there (is it always the main governance token, or is it just the address associated to ENS name? can we parse Snapshot's data to add other contract addresses)
  • Change "@context": "<http://www.daostar.org/schemas>", everywhere to "@context": ["https://www.snapshot.org", https://www.daostar.org/schemas"],
  • Snapshot needs to publish an issuerURI as specified in DAOIP-3, as technically all 4824-compliant data being published through the Snapshot Hub is an attestation from Snapshot. That is, absent a DAO "claiming" this data by referencing it in their own daoURI, indexers will want to be able to distinguish information that Snapshot publishes about a DAO from information that DAOs publish themselves. I will create a separate PR for this.

Actual behavior

None of the above currently happens.

Steps to reproduce the behavior

Note, this issue is also referenced in the DAOstar GitHub at metagov/daostar#205 and related issues linked there.

@Rashmi-278
Copy link
Contributor

Updated the PR to reflect Fabian's comments, #812

@Rashmi-278
Copy link
Contributor

Rashmi-278 commented Apr 22, 2024

@thelastjosh

None of the subsidiary URIs (membersURI, proposalsURI, activityLogURI, or contractsURI return well-formed URLs. In particular, there is an extra / when appending the right information.

Could you please share more details on the expected behavior for this? Do you main trailing '/' on the URL? They work without the trailing slash

Snapshot needs to publish an issuerURI as specified in DAOIP-3, as technically all 4824-compliant data being published through the Snapshot Hub is an attestation from Snapshot. That is, absent a DAO "claiming" this data by referencing it in their own daoURI, indexers will want to be able to distinguish information that Snapshot publishes about a DAO from information that DAOs publish themselves. I will create a separate PR for this.

Please assign this PR to me when you create it

@Rashmi-278
Copy link
Contributor

Context updated: Check here

@Rashmi-278 Rashmi-278 linked a pull request May 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants